search

bkaradzic / bgfx.cmake

CMake build scripts for bgfx. Released under public domain.
Creative Commons Zero v1.0 Universal
210 stars 111 forks source link

Fixing Wayland cmake definitions and linkage #250

Closed mtytel closed 1 week ago

mtytel commented 1 month ago

In newer versions of cmake this line triggers a CMP0127 warning. Removing the quotes because they're not needed in older versions of cmake and doesn't trigger the warning in newer version of cmake.

mtytel commented 1 month ago

So 'Linux' actually wasn't matching CMAKE_SYSTEM_NAME and removing the single quotes makes it match so it turned on WAYLAND by default in the build above. That exposed some missing definitions and library linkage so I've fixed that here.

I also turned off wayland by default which is how it was behaving originally (because it never matched 'Linux')

Gaspard-- commented 1 month ago

Disclaimer: not a maintainer.

So 'Linux' actually wasn't matching CMAKE_SYSTEM_NAME and removing the single quotes makes it match so it turned on WAYLAND by default in the build above. That exposed some missing definitions and library linkage so I've fixed that here.

I also turned off wayland by default which is how it was behaving originally (because it never matched 'Linux')

I think wayland is supposed to be turned on by default: #234 I haven't updated bgfx.cmake to test, so maybe #232 wasn't actually fixed. This would also explain #249

bwrsandman commented 1 month ago

There was a lot of push recently in the distro and DE space this year to ditch XOrg finally. I would prefer to keep Wayland as default as long as it's working.

mtytel commented 1 month ago

It actually wasn't enabled by default before, it just looked like it was. I turned it on by default it the last couple commits though and added some installation requirements for CI.

mtytel commented 4 weeks ago

Alright squashed my changes.

It looks like the bgfx.cmake's bgfx amalgamated build doesn't work with wayland enabled but it compiles on newer bgfx. So I could update the bgfx ref.

mtytel commented 3 weeks ago

I bumped bgfx version so the amalgamated build with wayland enabled works. CI is passing in my fork.

mtytel commented 1 week ago

@bwrsandman this is ready to pull in.