search

bkaradzic / bgfx

Cross-platform, graphics API agnostic, "Bring Your Own Engine/Framework" style rendering library.
https://bkaradzic.github.io/bgfx/overview.html
BSD 2-Clause "Simplified" License
15.04k stars 1.95k forks source link

Nanogui port #1953

Closed dalerank closed 2 years ago

dalerank commented 4 years ago

hello, @bkaradzic I ported my small ui library for bgfx, could you include it to examples? bgfx_nanogui_port

bkaradzic commented 4 years ago

It would be better if I add info about into README.md (here: https://github.com/bkaradzic/bgfx#who-is-using-it-madewithbgfx) instead into examples. That way you could maintain it independently from bgfx.

dalerank commented 4 years ago

So I need create external repo for it?

dalerank commented 4 years ago

@bkaradzic hi again look at https://github.com/bkaradzic/bgfx/pull/1955 pls, or you think it better move to external? but nanogui just a small ui library

bkaradzic commented 4 years ago

This is bad: https://github.com/bkaradzic/bgfx/pull/1955/commits/f27065dac3c61d463c3c2aaac749802d5ad8235a#diff-ae23827c1456b55269dd5a87efe917fa

I want things in bgfx buildable without going through extra build instructions.

Also Nanogui for some reason requires Eigen library which is pretty big dependency.

You should create nanogui-bgfx repo, and I'll link from README.

dalerank commented 4 years ago

Yep, eigen too huge, also look into how to exclude this depends from repo...