Examples: change order of calls in loadTexture()

bkaradzic / bgfx

Cross-platform, graphics API agnostic, "Bring Your Own Engine/Framework" style rendering library.

https://bkaradzic.github.io/bgfx/overview.html

BSD 2-Clause "Simplified" License

15.05k stars 1.94k forks source link

Examples: change order of calls in loadTexture() #3281

Closed aleksandrbazhin closed 6 months ago

aleksandrbazhin commented 6 months ago

Fixes possible concurrency issue - makes code usable in a multithreaded environment. imageReleasCb releases imageContainer after bgfx::createTexture...() is called. If bgfx::frame() is called from another thread, the release can happen before imageContainer is used in bgfx::calcTextureSize(), leading to a crash. Although loadTexture() is not used in multithreaded environment in the examples, calling bgfx::calcTextureSize() before bgfx::createTexture...() is a better reference for users.