Minimal changes to update pssl support.

bkaradzic / bgfx

Cross-platform, graphics API agnostic, "Bring Your Own Engine/Framework" style rendering library.

https://bkaradzic.github.io/bgfx/overview.html

BSD 2-Clause "Simplified" License

15.12k stars 1.95k forks source link

Minimal changes to update pssl support. #3355

Open kalmard0 opened 1 month ago

kalmard0 commented 1 month ago

Fix a line in bgfx_shader.sh (tested locally).
Update the shader embedding macro to match the other macros.
Update embedded shader generating make rules to output the same style for PSSL as the other rules (but empty arrays).

Some of the changes are not well tested as I'm having trouble (re-)generating all shaders in my dev environment.

kalmard0 commented 1 month ago

Friendly ping @bkaradzic

bkaradzic commented 1 month ago

I didn't quite get what you're doing from looking at the change. And then I forgot to look closer...

kalmard0 commented 1 month ago

I didn't quite get what you're doing from looking at the change. And then I forgot to look closer...

It's a bunch of small fixes for pssl that makes it easier to merge public bgfx changes into my local repo :) And hopefully also for anyone else that uses pssl.

kalmard0 commented 1 week ago

Can you let me know if you're willing to accept this PR (or any part of it) or if I should close it?