search

bkardell / common-panel

An effort to define a new element with clear semantics and separation
14 stars 3 forks source link

Standardise attribute names #14

Closed LJWatson closed 9 years ago

LJWatson commented 9 years ago

We might want to standardise attribute names, and at the same time bring them in-line with existing HTML attribute names?

We currently have "is-removable", "expanded-state" and "preferred-display". Perhaps "removable", "expanded" and "display" would work - along the lines of "checked" and "selected" etc.?

bkardell commented 9 years ago

I think there is discrepancy within the spec, and definitely between spec and prototype about whether it is called "expansion-state" or "expanded-state".. The key is that it cannot be a boolean, it needs to be "opened" or "closed" (currently the default if present but unspecified is "opened" and specified behavior exists if it is anything else). This is all defined in 4.3... But, yes, I think removable/expanded would work.

Preferred-display is from another proposal and I don't think "display" works, we probably need thought on that one. "preference" is probably better.

LJWatson commented 9 years ago

The latest draft of the spec uses <panel>, <paneltitle>, <panelset>, removable, expandable and prefereddisplay.