search

bkardell / common-panel

An effort to define a new element with clear semantics and separation
14 stars 3 forks source link

Missing alts on images #2

Closed LJWatson closed 9 years ago

LJWatson commented 9 years ago

The images in panel.html need alt attributes/text.

bkardell commented 9 years ago

I struggled with how to do this well. As it is defining a separation between visual and useful, accessible structure, it's useful to show presentational related things, as well as describe the structure. The only images in here are demonstrating without an implementation what something might 'look' like visually. What kind of alt text would I use to make that helpful? I assumed that without alt text it would simply skip the image which seemed ok to me, but I'm very open to direction, help or pull here.

On Dec 10, 2014 4:35 AM, "Léonie Watson" notifications@github.com wrote:

The images in panel.html need alt attributes/text.

— Reply to this email directly or view it on GitHub https://github.com/bkardell/common-panel/issues/2.

LJWatson commented 9 years ago

If the images don't provide any information beyond what's in the text content, then a null alt can be used (alt=""). This will cause ATs to ignore the images completely. If the image doesn't have an alt attribute some ATs will announce the file path instead.

I'll add the alts in my next commit.

@LeonieWatson Carpe diem

From: Brian Kardell [mailto:notifications@github.com] Sent: 10 December 2014 22:42 To: bkardell/common-panel Cc: Léonie Watson Subject: Re: [common-panel] Missing alts on images (#2)

I struggled with how to do this well. As it is defining a separation between visual and useful, accessible structure, it's useful to show presentational related things, as well as describe the structure. The only images in here are demonstrating without an implementation what something might 'look' like visually. What kind of alt text would I use to make that helpful? I assumed that without alt text it would simply skip the image which seemed ok to me, but I'm very open to direction, help or pull here.

On Dec 10, 2014 4:35 AM, "Léonie Watson" notifications@github.com wrote:

The images in panel.html need alt attributes/text.

— Reply to this email directly or view it on GitHub https://github.com/bkardell/common-panel/issues/2.

— Reply to this email directly or view it on GitHub https://github.com/bkardell/common-panel/issues/2#issuecomment-66538348 . https://github.com/notifications/beacon/ADVr6bULl6APr6H04tHy1sXoosvc5J84ks5nWMOkgaJpZM4DGlm9.gif

bkardell commented 9 years ago

I added on my last commit. Also removed panels.html and merged your changes into index.html - apologies for confusion.