search

bkavuncu / GDO

GDO
MIT License
0 stars 1 forks source link

Do components dev #170

Closed senakafdo closed 7 years ago

senakafdo commented 7 years ago

Please review and merge the following commits in to the Dev branch. These are a part of a series of improvements that we are working on for the DO Software Framework. The idea here is to create some core components. The list of changes in this PR are as follows:

Thanks, Senaka.

miguems commented 7 years ago

HI Senaka, Jingqing

Great work! I am not able to follow all the changes as I have not being involved in this project or managing it, but I am sure you guys are doing a great job. David will be able to provide a more detailed feedback on the code.

Just checking… all this changes so far, if merged into dev, will everything keep working the same, right? From my understanding, this is just a refactoring to facilitate the next steps towards the final functionality, right?

If that is not the case (i.e. there are some existing functionalities being broken or missing in this pull request) I would advise not to merge it into dev yet. As things stands right now, dev is the only branch that we know works reliably. Master is now 6 months old…

Regards!

De: Senaka Fernando [mailto:notifications@github.com] Enviado el: miércoles, 12 de julio de 2017 0:00 Para: bkavuncu/GDO GDO@noreply.github.com CC: Subscribed subscribed@noreply.github.com Asunto: [bkavuncu/GDO] Do components dev (#170)

Please review and merge the following commits in to the Dev branch. These are a part of a series of improvements that we are working on for the DO Software Framework. The idea here is to create some core components. The list of changes in this PR are as follows:

Thanks, Senaka.

You can view, comment on, or merge this pull request online at:

https://github.com/bkavuncu/GDO/pull/170

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/bkavuncu/GDO/pull/170, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEurBZMn8HUiiIWs8UmbmPvU3MBzeTmhks5sM_BYgaJpZM4OU3sj.

senakafdo commented 7 years ago

Hi Miguel,

You are correct that this is just a refactoring to facilitate further improvements. And, we would continue to refactor further (while introducing improvements) even after merging the PR, as noted to David on Slack.

Best Regards, Senaka.

davidbirchwork commented 7 years ago

Merging the pull request to enable issues identified to be worked on :)