search

bkavuncu / GDO

GDO
MIT License
0 stars 1 forks source link

ImagesApp: deterministic digits generation #185

Open nw0 opened 6 years ago

nw0 commented 6 years ago

We want to have the digits generated deterministically, so that we can refer to it easily via Scenarios or the API. Remark: previously, digits already strings.

  1. Refactor basePath magic constants out of ImagesApp.cs
  2. Refactor image saving (a controller task) out of Control.cshtml to ImagesApp.cs
  3. Refactor post-saving tasks (saving in digits directory; thumbnail creation) to ImagesApp.cs
  4. Generate digits deterministically based on MD5 sum of original file contents
davidbirchwork commented 6 years ago

Thank you for this, it looks good. Would it be possible to extend this to include a delete button then we can test both together?

nw0 commented 6 years ago

The current app does not delete the source images; should this change? I presume you mean remove from the database and the images themselves.

davidbirchwork commented 6 years ago

yes please adding a gui control button linked to a hub method to delete a source image, and its shards, and remove it from database would be ideal