search

bkchung / mod-spdy

Automatically exported from code.google.com/p/mod-spdy
0 stars 0 forks source link

Add support for remaining filter read modes #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I added lots of CHECKs initially, but now that we're getting to the point of 
having a semi-productionizable module, we need to convert these to DCHECKs 
and add appropriate error handling in release builds.

Original issue reported on code.google.com by bmcqu...@google.com on 26 Feb 2010 at 1:07

GoogleCodeExporter commented 9 years ago

Original comment by bmcqu...@google.com on 26 Feb 2010 at 1:08

GoogleCodeExporter commented 9 years ago 
The only remaining CHECK is in http_stream_accumulator.cc where we implement 
reading 
from filters. There are a few read types we don't yet support so we CHECK if we 
encounter these read types.

Original comment by bmcqu...@google.com on 8 Mar 2010 at 11:29

GoogleCodeExporter commented 9 years ago 
This is no longer an issue -- the new SPDY-to-HTTP input filter handles all 
read modes (except for EATCRLF, for which it returns APR_ENOTIMPL, as does 
mod_ssl).

Original comment by mdste...@google.com on 20 Dec 2011 at 7:47