Closed kriansa closed 9 months ago
@kriansa Yep, that sounds reasonable. Do you want to work up a pull request with tests?
Sure, will send a patch shortly
@bkeepers I opened a PR, (#489). Lmk if it looks ok
interesting, I just bumped activesupport from 7.0.8
to 7.0.8.1
and hit this error
https://github.com/bkeepers/dotenv/blob/6dd03851298c4bd250c36ef14ba253892db04063/lib/dotenv/rails.rb#L91-L96
This initializer wraps the existing Rails logger into
ActiveSupport::TaggedLogging
, which for the default Rails config is not bad, but when custom loggers are in place, it could be troublesome.I, for instance, currently have a custom logger that mimics
TaggedLogging
and supports its interface. I think we should just test if the existing Rails logger responds to.tagged
and then call it instead of re-wrapping it. Something like that (haven't tested yet):What do you think? By the way, awesome work on the new release! :+1: