search

bkeepers / qu

a Ruby library for queuing and processing background jobs.
MIT License
505 stars 50 forks source link

Relax Rails dependency and depend on railties instead of rails itself #81

Closed mauricio closed 10 years ago

mauricio commented 10 years ago

The Railties API hasn't changed between Rails 3 and 4, so the dependency can be made compatible with Rails 4 as well. Also changed it to depend on railties instead of rails itself.

jnunemaker commented 10 years ago

Looks like the log subscribers have changed from 3 => 4.

mauricio commented 10 years ago

@jnunemaker I have run workers in a sample app here and they were all fine. But I can include tests to validate this as well.

What do you think?

jnunemaker commented 10 years ago

You probably were not requiring the log subscribers.

Check out the build failures: https://travis-ci.org/bkeepers/qu/builds/18193019

mauricio commented 10 years ago

Cool, gonna check that and push again.

mauricio commented 10 years ago

@jnunemaker and here it is. The issue was caused by https://github.com/rails/rails/commit/a6fd462a8019f0be512bcba7ce5b9f9e482c7f8e, that logger instance method was hiding the logger class method that was used previously. Including it makes the specs go green on both cases.

Still, it would be nice to have specs running for both cases, should I include separate gemfiles to be run by travis for this?

jnunemaker commented 10 years ago

Still, it would be nice to have specs running for both cases, should I include separate gemfiles to be run by travis for this?

:+1: I would love that.

jnunemaker commented 10 years ago

Merged this. You can add the separate gemfiles in another pull when you get time.