search

bkeepers / strappydoo

bootstrap and run any project with the same command
MIT License
77 stars 7 forks source link

Closes #7 Add support for Elixir Phoenix #8

Closed fapdash closed 6 years ago

fapdash commented 6 years ago

@bkeepers All the commands are working except for strappy server. Phoenix projects have a package.json file in the top directory and so the npm_server command is triggered.

$ ls
brunch-config.js  deps     mix.lock      package-lock.json  test
_build            lib      node_modules  priv               web
config            mix.exs  package.json  README.md

Would it be possible to make the npm_server check more specific?

bkeepers commented 6 years ago

Would it be possible to make the npm_server check more specific?

Definitely. Any suggestions on what the heuristics should be for detecting npm vs phoenix?

fapdash commented 6 years ago

Definitely. Any suggestions on what the heuristics should be for detecting npm vs phoenix?

By default Phoenix doesn't define a npm start script so checking for that should be enough. I've added a check to the change.

bkeepers commented 6 years ago

Thanks @fapdash. I pushed a few fixes after testing it locally, but everything looks good now.