bkhpanigha / hh-suttas

HH Suttas (Development)
https://hh-suttas.onrender.com/
9 stars 7 forks source link

Add suttas content search #167

Closed interested-in-dhamma closed 1 month ago

interested-in-dhamma commented 1 month ago

Done

Core:

Additional:

Todo

Notes

bkhpanigha commented 1 month ago

@interested-in-dhamma Good work, it seems to work well so far. Two things I would consider essential before rolling it out: (1) The ability to match with or without diacritics (e.g., find "jhāna" when typing "jhana") (2) Searching Pāli titles at the very least, since those are standard and more known, while the English titles vary across translations.

Also, how hard would it be to display the actual text (i.e. the whole JSON entry containing the search string) under each hit, like this? image

interested-in-dhamma commented 1 month ago

@bkhpanigha The 2 points have been addressed. The pali is now completely searchable as well. (Including the title of the sutta). Additionally, the comments are also searchable now.

I will get back to your point about displaying of the text.

Reptilioo commented 1 month ago

This is not extremely important for now but if I understand correctly: the database is only updated when new suttas are added and not when modifications are made in the already existing ones, right?

interested-in-dhamma commented 1 month ago

Yes that is right, I did not consider that during the implementation @Reptilioo