WIP: Settings panel - Githubissues

bkhpanigha / hh-suttas

HH Suttas (Development)

https://hh-suttas.onrender.com/

9 stars 7 forks source link

WIP: Settings panel #173

Closed uruvelakassapa closed 1 month ago

uruvelakassapa commented 1 month ago

This is a work in progress branch which attempts to move the toggle pali, dark mode and font size adjustments to a settings panel. The settings panel is accessible in two places.

Top of page:

Navbar when viewing suttas:

Along with adding some new functionality (and fixing the navbar behaviour), part of the motivation is fix the current covering up of text with the "Toggle Pali" button (see screenshot)

TODOs

[ ] save and load font size changes to local storage
[ ] fix css all over the place for the settings panel
[ ] remove dark mode button from html icon navbar
[ ] some other things that I haven't considered yet

It will be unlikely that I'll get a chance to make progress on this for the next few weeks. Hence why I'm putting it out there in the unlikely event that anyone feels inclined to move this along further.

wisecameron commented 1 month ago

So this settings panel will come in place of the current buttons, correct? And would you prefer to have a button that toggles visibility for the settings panel in itself? It might be wise to default to an open panel and use cookies to maintain the closed state once a user decides to dock it, that way we can guarantee that they are aware of its contents while keeping it non-intrusive if they decide to dock it.

uruvelakassapa commented 1 month ago

So this settings panel will come in place of the current buttons, correct?

Just the dark mode button. The others are ideally moved to a descriptive navbar of sorts. See #131

And would you prefer to have a button that toggles visibility for the settings panel in itself? It might be wise to default to an open panel and use cookies to maintain the closed state once a user decides to dock it, that way we can guarantee that they are aware of its contents while keeping it non-intrusive if they decide to dock it. I was planning to have it automatically hidden when opened from the suttas navbar (second image in OP) and static when from the top.

I think that's a simpler implementation but I'm ok with your approach as well if you'd like to develop that.

uruvelakassapa commented 1 month ago

I've created another branch with the logic integrated with the new restructure. Unfortunately I wasn't able to complete it before my longer break away from a laptop. Happy for alternative solutions, otherwise I'll try again mid December