search

bkhpanigha / hh-suttas

Hillside Hermitage Sutta Translations
6 stars 7 forks source link

"Copy Link" and "Add Bookmark" buttons no longer displaying for highlighted text #196

Open bkhpanigha opened 4 hours ago

Reptilioo commented 3 hours ago

Also links to passages aren't working anymore. For example: https://suttas.hillsidehermitage.org/?q=mn1#mn1:2.2-mn1:2.3 (which was valid before)

interested-in-dhamma commented 1 hour ago

Also links to passages aren't working anymore. For example: https://suttas.hillsidehermitage.org/?q=mn1#mn1:2.2-mn1:2.3 (which was valid before)

This also affects the return option from a comment to the text. (It is also a link.)

Reptilioo commented 1 hour ago

@interested-in-dhamma It is probably a missing reference or missing import or missing eventListener to function scrollToHash() in former './js/utils.js' somewhere. See #200 for a similar issue with "copy link" and "add bookmark" features.

bkhpanigha commented 33 minutes ago

@Reptilioo The buttons themselves now appear and successfully copy the selected link to the clipboard, but if you paste said link into a new tab you get a "not a valid citation" error.