search

bkhpanigha / hh-suttas

HH Suttas (Development)
https://hh-suttas.onrender.com/
9 stars 7 forks source link

Adv. search style modifications #244

Closed Reptilioo closed 1 week ago

Reptilioo commented 1 week ago

- Modified adv. search page theme to fit home page colors better

- Modified adv. search dark theme

- Added a left-border specific color to differentiate english, pali and comment content, as well as a label in the top right corner of the result

Contains modifications from #243

Feel free to let me know if this is too much, distracting or distasteful.

Also, would you mind if we had multiple polished site-wide themes to choose from in a setting menu?

Reptilioo commented 1 week ago

Also modified highlighting color of the search terms on the sutta page to match highlighting in search results.

bkhpanigha commented 1 week ago

@Reptilioo Before testing this, I was just about to suggest that we should distinguish the different types of results in some obvious way, and this works great.

Also, would you mind if we had multiple polished site-wide themes to choose from in a setting menu?

Could do, although it would be a low-on-the-priority list feature. Getting the settings menu itself (which could also contain things like Dark Mode, Use Offline, and Ebook download, and Reset Website) would probably be more important.

bkhpanigha commented 1 week ago

@Reptilioo Also, there are merge conflicts on this PR that are not immediately obvious to resolve. Could you take a look at them and submit a new PR once resolved?

Reptilioo commented 1 week ago

@bkhpanigha That is the first time I'm resolving conflicts, I corrected them all before I realised that there were really no reason to have conflicts since the HTML and CSS I'm PRing are the final version anyway, there was still a small difference of 7 lines corresponding to one css element, so I ended up just overwriting the code. Do you know if it can cause issues down the line on github side?

When you say "submit a new PR", do you mean litterally opening a new Pull Request?

bkhpanigha commented 1 week ago

When you say "submit a new PR", do you mean litterally opening a new Pull Request?

@Reptilioo Never mind. I wasn't sure if you'd be able to fix the conflicts from your side, but you were.

there was still a small difference of 7 lines corresponding to one css element, so I ended up just overwriting the code. Do you know if it can cause issues down the line on github side?

I don't think so. The issue would be for us if we end up pushing code that we didn't actually intend to use.