search

bkhpanigha / hh-suttas

HH Suttas (Development)
https://hh-suttas.onrender.com/
9 stars 7 forks source link

Search function not working #78

Closed Reptilioo closed 6 months ago

Reptilioo commented 6 months ago

Search function giving 404 errors in the js console and never returning any results

ghost commented 6 months ago

Thanks for notifying. I'll have a look into this

Reptilioo commented 6 months ago

After looking a bit into it I realize I might have misinterpreted what the search function is to be used for, it does search and find the suttas when searched with their id (like 'MN1'). I was just thinking it was also searching for words in titles and sutta's content and returning the corresponding suttas but I might be wrong on this

Reptilioo commented 6 months ago

Another thing, when typing letters in the search box, everytime a letter is entered the displayed list of suttas is duplicated. You can easily see that by typing a letter while checking the scroll bar height changing

You probably just need to replace "+=" by "=" in line 84 (index.js)

Reptilioo commented 6 months ago

There is also an issue with the classifying of the suttas with their respective books when doing a search.

Edit: we could just not display the nikaya <h2> during a search and maybe also configure fuse so as to exclude the suttas that don't include any of the search terms in their titles, instead of sorting them at the end of the list

Reptilioo commented 6 months ago

There is still an issue where when mixing search terms with part of the ID and part of the title, nothing will come up e.g. "sn mind" doesn't return sn47.8. Same when mixing part of the ID and part of the author name, or part of the title and part of the author name e.g. "snp medhini" doesn't return SNP4.1 / 4.2 / 4.3 / 4.4