search

bkiers / Liqp

An ANTLR based 'Liquid Template' parser and rendering engine.
MIT License
165 stars 94 forks source link

Update antlr4 dependency version from 4.7.2 to 4.13.0; update CI scripts to always build with Java 11 but still targeting and testing Java 8 #276

Closed kohlschuetter closed 1 year ago

kohlschuetter commented 1 year ago

This fixes a "unused import" warning in target/generated-sources.

kohlschuetter commented 1 year ago

This is blocked on the CI builds still running with Java 8.

Antlr changed their internal code to be Java 11+ only, even though the produced code still compiles for source/target version 8.

@msangel @bkiers Do we still need to run the v8 builds? Can we change them so they're building with Java 11 but run on Java 8?

msangel commented 1 year ago

Java 8 is still ~ 30% usage so that’s why it stick with antlr3. Let’s keeping it until usage of it will be much lower. IMG_2300

msangel commented 1 year ago

Oh, sorry. So we can compile j11, but have it running on 8? Cool. And what’s are benefits of antlr 4 for this project? It simply works well!

kohlschuetter commented 1 year ago

We already use antlr4 exclusively; they just bumped the build requirements to Java 11 at some point.

kohlschuetter commented 1 year ago

@msangel I've updated the Github script so we can build with Java 11 and still test with Java 8. Everything works now :)