Spurious test failures with FiniteDuration - Githubissues

bkirwi / decline

A composable command-line parser for Scala.

http://monovore.com/decline/

Apache License 2.0

647 stars 71 forks source link

Spurious test failures with FiniteDuration #318

Open mdedetrich opened 3 years ago

mdedetrich commented 3 years ago

FiniteDuration tests seem to be sometimes randomly failing when working with microseconds, see the logs below

https://github.com/bkirwi/decline/pull/317/checks?check_run_id=3054763663 https://pipelines.actions.githubusercontent.com/QKeYrpG6uBdre3U4Fj5bCes4Aeh9fxEfaXGCGNvwjOGcfRYSTr/_apis/pipelines/1/runs/56/signedlogcontent/3?urlExpires=2021-07-13T08%3A32%3A07.2794405Z&urlSigningMethod=HMACV1&urlSignature=jPSh7rmRs99X0g3%2BRV2oJQxKWxze5qWsXjI6c%2BaZ4fs%3D

I think there may be some lossy data being lost due to precision issues

bkirwi commented 3 years ago

(For any bystanders: FiniteDuration was just added in https://github.com/bkirwi/decline/pull/310.)

Looks like the logs have been GC'd, but that sounds like a likely diagnosis. May need to tweak / filter the ScalaCheck generator?