bkjwjason / pe

0 stars 0 forks source link

Incorrect Error Message #2

Open bkjwjason opened 1 year ago

bkjwjason commented 1 year ago

When adding a recruiter to an organization that does not exist, the error message is incorrect for cases where there are extra parameters.

For example, this is the intended output since there is no organization with the oid newOrg. Screenshot 2023-11-17 at 4.36.01 PM.png

However, adding extra parameters to input shows that the --number tag is irrelevant.

Steps to recreate the bug:

  1. add a recruiter linked to an organization that does not exist. The --number field must be supplied.

Screenshot 2023-11-17 at 4.34.06 PM.png

This is the same for the sample command given in the UserGuide. Screenshot 2023-11-17 at 4.38.07 PM.png

This bug does not happen if the command is inputted without the --number field.

This has been classified as severity.medium since users may enter a recruiter's information without the organization being inside, and the output message is different from what the UG stated: --number is a optional parameter, not a irrelevant parameter.

nus-se-script commented 1 year ago

Team's Response

This is the same as issue #5531 as this is a mistake made in the UG.

Specifically, we incorrectly referenced --number, but there is no such parameter in the add command. It is supposed to be the --phone parameter.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect add example command as number field does not exist

image.png In the add command, the bottom-most example command is incorrect as the number field should be phone instead. Copy and pasting it into the programme gives me this

image.png


[original: nus-cs2103-AY2324S1/pe-interim#5236] [original labels: type.DocumentationBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Agreed, this was a mistake on our end. The --number flag should have been --phone instead.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]