search

bkkhack / hackmap

App to help collaboration at hacknights.
https://bkkhack.github.io/hackmap/
MIT License
10 stars 9 forks source link

Allow moderators to move around any other person #70

Open djay opened 5 years ago

djay commented 5 years ago

It would be very useful as people are shy to place themselves on the map. The admins can sort people into groups ahead of time.

waf commented 5 years ago

This should already be implemented as part of https://github.com/bkkhack/hackmap/issues/9 . As long as you're logged in and you either have "MEMBER" or "OWNER" role, you can place anybody.

djay commented 5 years ago

I can't move people around. I think I'm "Maintainer"

waf commented 5 years ago

@djay according to the api you're coming back as a User for this repo.

Is it possible you have to join this repo specifically?

ches commented 5 years ago

Doesn't work for me either, I tried adding the "Organizers" team explicitly to this repo, with Admin level, and then also added myself individually to this repo as an explicit collaborator. Neither made a difference.

I didn't start debugging with API responses yet, but there might still be a bug with implementation, and/or we can maybe use a way to roles from the organization level for this case.

waf commented 5 years ago

Thanks @ches for looking into this. Now, I can no longer move avatars either. I've verified that my user is also coming back "type: User" now.

It's unclear to me when "type" is anything other than User now. I can't find any change announcements from GitHub either. Possibly we need to use a different API to get organization membership.

waf commented 5 years ago

If we can't rely on "user.type" to have the correct value, we could potentially start using "comment.author_association" in that same API response. I'd prefer to use this property, if possible, so we don't need to introduce the overhead of another API request/response