search

bklieger-groq / stockbot-on-groq

StockBot powered by Groq: Lightning Fast AI Chatbot that Responds With Live Interactive Stock Charts, Financials, News, Screeners, and More. Powered by Llama3-70b on Groq, Vercel AI SDK, and TradingView Widgets.
https://groq-stockbot.vercel.app
Other
1.03k stars 173 forks source link

New Feature: stock comparison #29

Closed Mustafa-Esoofally closed 3 months ago

Mustafa-Esoofally commented 3 months ago

Compare 2 or more tickers side by side.

stockBot compare stocks

vercel[bot] commented 3 months ago

@Mustafa-Esoofally is attempting to deploy a commit to the bklieger-groqcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

Mustafa-Esoofally commented 3 months ago

I have made all the requested changes

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
groq-stockbot ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 7:44pm
bklieger-groq commented 3 months ago

@Mustafa-Esoofally for proper git hygiene, please squash your commits into one (instructions) with the prefix "feat: " and the description of the feature.

Also ensure in the code that all stocks in the chart, both comparison and original, are of the same chart type. In other words, if one is bar chart, they should all be bar. Or if one is line, they should all be line. This looks different in the provided image where one is candlestick and the others are line.

Afterwards I will run the code and prepare for merging the PR.

Mustafa-Esoofally commented 3 months ago

I have made the changes to the chart. It will be line chart for all comparisons.

I am a little unsure how to merge the commit since I have been working on multiple branches. Could you not just squash and commit the PR??

bklieger-groq commented 3 months ago

Merged into dev branch with PR to clean up history before merging to main. Closing this PR as it is now a duplicate.