Compliation error

[norrisryan]

Run into an issue when compiling liboi (GLuint not recognized). Adding #include <GL/gl.h> on line 55 of liboi.hpp fixed it.

[bkloppenborg]

Liboi shouldn't have a dependency on OpenGL-related functions. I wonder if the error originated elsewhere. Can you give me the exact compilation error?

[norrisryan]

[ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ccoifits.dir/PathFind.cpp.o [ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ccoifits.dir/COIVisRow.cpp.o [ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ccoifits.dir/COI_DATA_TABLE.cpp.o [ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ccoifits.dir/calibrators/CUniformDisk.cpp.o [ 23%] Linking CXX shared library ../../../../lib/libccoifits.so [ 23%] Built target ccoifits [ 23%] Building CXX object lib/textio/src/CMakeFiles/textio.dir/ReadTextFile.cpp.o [ 23%] Linking CXX shared library ../../../../lib/libtextio.so [ 23%] Built target textio Scanning dependencies of target oi [ 23%] Building CXX object src/CMakeFiles/oi.dir/CRoutine_DFT.cpp.o In file included from /home/norris/SOFTWARE/liboi/src/CRoutine.h:78:0, from /home/norris/SOFTWARE/liboi/src/CRoutine_FT.h:37, from /home/norris/SOFTWARE/liboi/src/CRoutine_DFT.h:35, from /home/norris/SOFTWARE/liboi/src/CRoutine_DFT.cpp:36: /home/norris/SOFTWARE/liboi/src/liboi.hpp:228:22: error: ‘GLuint’ has not been declared void SetImageSource(GLuint gl_device_memory, LibOIEnums::ImageTypes type); ^ src/CMakeFiles/oi.dir/build.make:62: recipe for target 'src/CMakeFiles/oi.dir/CRoutine_DFT.cpp.o' failed make[2]: [src/CMakeFiles/oi.dir/CRoutine_DFT.cpp.o] Error 1 CMakeFiles/Makefile2:569: recipe for target 'src/CMakeFiles/oi.dir/all' failed make[1]: [src/CMakeFiles/oi.dir/all] Error 2 Makefile:149: recipe for target 'all' failed make: *** [all] Error 2

[bkloppenborg]

Ah, ok. I forgot about this function. I'll fix this tonight unless you want to send in a pull request against liboi's develop branch.

On Wed, May 3, 2017 at 1:17 PM, norrisryan notifications@github.com wrote:

[ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ ccoifits.dir/PathFind.cpp.o [ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ ccoifits.dir/COIVisRow.cpp.o [ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ ccoifits.dir/COI_DATA_TABLE.cpp.o [ 23%] Building CXX object lib/ccoifits/src/CMakeFiles/ ccoifits.dir/calibrators/CUniformDisk.cpp.o [ 23%] Linking CXX shared library ../../../../lib/libccoifits.so [ 23%] Built target ccoifits [ 23%] Building CXX object lib/textio/src/CMakeFiles/ textio.dir/ReadTextFile.cpp.o [ 23%] Linking CXX shared library ../../../../lib/libtextio.so [ 23%] Built target textio Scanning dependencies of target oi [ 23%] Building CXX object src/CMakeFiles/oi.dir/CRoutine_DFT.cpp.o In file included from /home/norris/SOFTWARE/liboi/src/CRoutine.h:78:0, from /home/norris/SOFTWARE/liboi/src/CRoutine_FT.h:37, from /home/norris/SOFTWARE/liboi/src/CRoutine_DFT.h:35, from /home/norris/SOFTWARE/liboi/src/CRoutine_DFT.cpp:36: /home/norris/SOFTWARE/liboi/src/liboi.hpp:228:22: error: ‘GLuint’ has not been declared void SetImageSource(GLuint gl_device_memory, LibOIEnums::ImageTypes type); ^ src/CMakeFiles/oi.dir/build.make:62: recipe for target 'src/CMakeFiles/oi.dir/CRoutine_DFT.cpp.o' failed make[2]: [src/CMakeFiles/oi.dir/CRoutine_DFT.cpp.o] Error 1 CMakeFiles/Makefile2:569: recipe for target 'src/CMakeFiles/oi.dir/all' failed make[1]: [src/CMakeFiles/oi.dir/all] Error 2 Makefile:149: recipe for target 'all' failed make: *** [all] Error 2

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bkloppenborg/liboi/issues/49#issuecomment-298976675, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0ZUifKdAFPWxHcmHmRbWPwDE0lbVqcks5r2LangaJpZM4NPsXJ .

[bkloppenborg]

@norrisryan That include command is already on line 55 of the master branch here: https://github.com/bkloppenborg/liboi/blob/master/src/liboi.hpp#L55

Do you have an old version or perhaps different branch of the library?