search

bkloppenborg / simtoi

The SImulation and Modeling Tool for Optical Interferometry
GNU General Public License v3.0
7 stars 6 forks source link

Starspot location #111

Closed therob762 closed 9 years ago

therob762 commented 9 years ago

It would be nice to somehow convert phi and theta into stellar longitude and stellar latitude.

bkloppenborg commented 9 years ago

Great idea! The theta and phi values are in spherical polar coordinates (whether it is the mathematical or physical convention, I don't recall off-hand). In this case the longitude is analogous with theta and phi is the co-latitude (theta = 90 - delta with delta being the latitude). I would insist that the internal scheme in SIMTOI remain spherical-polar for consistency with other models, but changing how the user-supplied parameters are interpreted is fine. Please send in a pull request which renames theta and phi to latitude and longitude (once you confirm the spherical-polar convention convention) and convert these variables to theta and phi for use within the spot's apply function.

bkloppenborg commented 9 years ago

In commit e80f272b7f9bd8892356ac3e294989d0cff41628 we explicitly specify the role of theta and phi for spots. Users can convert these values to latitude and longitude manually if they wish.