search

bkloppenborg / simtoi

The SImulation and Modeling Tool for Optical Interferometry
GNU General Public License v3.0
7 stars 6 forks source link

Changed parameter names adding more description and units #112

Closed therob762 closed 9 years ago

bkloppenborg commented 9 years ago

Please revert all changes to the disk models. The parameters were listed in this fashion to precisely match those used in the papers from which the models were inspired. We will need to make this clear in the wiki by listing the LaTeX equation.

Many of the names are now excessively long, occupying nearly 1/6 of my (1080p) screen. Displaying this much information seems unnecessary when the users could just read the documentation. I'm ok with adding abbreviated units in parenthesis, but nearly complete sentences like "Position angle from N rotating E (degs)" are unnecessary because we will (soon?) have documentation on the wiki. In the case of position angle, the direction should be obvious (from astronomical conventions), but to make this clear we should explicitly state so in external documentation.

P.S. Ignore the Travis build failure message, this is an error with CMake on Travis-CI rather than anything wrong with your code.

bkloppenborg commented 9 years ago

Please fix the above issues and re-submit the pull request against the develop branch. You can do this by choosing the branch when you submit the pull request.