Closed fabienbaron closed 8 years ago
Now also improved grid search output.
Could you make a few changes:
I'm not sure about the performance impact of printing data to the console for the grid search. This could result in a loss of performance as writing to the console is much more lengthy than most of SIMTOI's operations. What are your thoughts?
By the way, the auto_ptr -> unique_ptr change needed to be made in ccoifits
. I just pushed that change upstream and propagated it down to SIMTOI's develop branch.
After discussions with Fabien on this PR, I will have to add a removeParameter function to the parameterMap class to fix item 2. I'll also fix item 1 at the same time.
This adds a Roche lobe model based on fill factor. Also fixes minor issues with classic (r_pole based) Roche lobe model.