bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add construction/destruction tests for the CSR matrix class #23

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

This task adds tests to verify the implementation of the constructors and destructors for the CSR matrix class in the SparseMatrix library. This does not add functionality critical to the function of the code but it is crucial to the requirement "The library shall provide interfaces to return or define a matrix in CSR format." It's important to test this to make sure that we are able to construct the CSR type and properly clean up the memory allocation.

Tasks:

Definition of done:

This will be done when all unit tests are implemented and pass.

KyleVaughn commented 11 months ago

Review by @Aravind-Kulanthaivelu

Aravind-Kulanthaivelu commented 11 months ago

This issue is well defined and addresses all the points necessary. A suggestion would be to elaborate the type of bogus data that is given as an input while checking for the error handling capabilities of the constructors and destructors such as edge cases or providing a negative value for our array size.

lwh1106 commented 10 months ago

Hi, the CSR class has been added to the "csr" branch. Just let me know if there are any bugs ...