search

bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add construction/destruction tests for the JDS matrix class #25

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

Add construction and destruction tests for the JDS matrix class to ensure that the matrix is properly constructed or destructed. Includes AssembleStrorage() and DisassembleStorage() as defined in the "Add a JDS matrix class" issue.

Tasks:

-[] Test whether matrix class has been constructed -[] Test AssembleStorage() to ensure vectors have been allocated correctly -[] Test DisassembleStorage() to ensure data returns to the general data format in SparseMatrix -[] Test whether destruction works

Definition of done:

The issue is resolved when the units tests have all passed. The construction unit test will be passed if the matrix class exists. The destruction unit test will be passed if the matrix class does not exist. The AssembleStorage() test will pass if all the vectors are the correct size. The DisassembleStorage() test will pass if the storage vectors don't exist.

KyleVaughn commented 11 months ago

Review by @shujhan

shujhan commented 11 months ago

It may be better to add some print out in Tasks for each task. I wonder why we test AssembleStorage() and DIsassembleStorage() methods here. Should they be sepreated into another test method?