bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add tests for the COO matvec method #29

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

The matvec method of the COO class will be tested for a combination of matrices and vectors with known results. Correct size of the output will also be tested.

Tasks:

Implement a test for COO matvec method which catches possible errors like

Definition of done:

Developing tests that test the accuracy of the matvec method

Lazy-Beee commented 11 months ago

I would suggest using the function interface virtual fp_type* matvec(fp_type* vecin) and I'll add this to the SparseMatrix class.


Edit: change the api to avoid memory leak void matvec(fp_type* vecin, fp_type* vecout)

KyleVaughn commented 11 months ago

Review by @AnvayPradhan

AnvayPradhan commented 11 months ago

Would recommend multiple matrices and vectors with known outputs instead of just one to test with this matvec method

sthvkbht commented 11 months ago

Yes. That is the plan. Will make it more clear.