Add tests for the CSR matvec method

[KyleVaughn]

Description:

This task adds a program to test the CSR matvec method. This would be considered a Unit Test. This task does not directly satisfy any of the functional requirements, but it is critical to the requirement "The library shall provide an interface to perform sparse matrix vector multiplication". Tests are an important in programming because they ensure the program performs as expected in a variety of use cases.

Tasks:

• [ ] Communicate with implementer of CSR matvec method.
• [ ] Define a way to verify the output of the CSR matvec method. This will likely include using the input and output vector files we defined in HW2
• [ ] Define the ways we want to test invalid input for the CSR matvec method
• [ ] add tests that verify output for the CSR matvec method
• [ ] add tests that uses invalid and valid input to see how the CSR matvec method handles it
• [ ] define the tests for the CSR matvec method in a way that is compatible with cmake and make so that it is called when make test is called

  Definition of done:

  The test runs successfully when called by make tests. The test for the CSR matvec operation runs successfully when the program returns the correct answer for valid input and exits with invalid input.

[Lazy-Beee]

I would suggest using the function interface virtual fp_type* matvec(fp_type* vecin) and I'll add this to the SparseMatrix class.

---

Edit: change the api to avoid memory leak void matvec(fp_type* vecin, fp_type* vecout)

[KyleVaughn]

Review by @marchier

[marchier]

Description section for the CSR matvec operation looks well defined

For the Tasks section, include the label that the inputs you are looking for are in the CSR format (ex. mention that a "valid input" is in the CSR format)

For the Definition of done section, it should be specified that the tests are for the CSR format and matvec operation

[jacob-umich]

@marchier

For the Tasks section, include the label that the inputs you are looking for are in the CSR format (ex. mention that a "valid input" is in the CSR format)

Wouldn't valid input just be a vector? Those don't have any specific format, right?

---

it should be specified that the tests are for the CSR format and matvec operation.

It has been clarified!

[marchier]

@marchier

For the Tasks section, include the label that the inputs you are looking for are in the CSR format (ex. mention that a "valid input" is in the CSR format)

Wouldn't valid input just be a vector? Those don't have any specific format, right?

For the tasks section suggestion, I meant that you should clarify that the tasks should all mention that they are for the CSR format (similar to the Definition of Done suggestion, I apologize for the unclear review comment)

[jacob-umich]

Roger that. it has been updated for clarity. Thank you for the feedback.