Add assembleStorage and disassembleStorage tests for COO

[KyleVaughn]

Description:

In order to make sure that the assembleStorage and disassembleStorage methods are working properly, we need to test that the conversion to and from the COO format is being done correctly.

These tests will identify possible errors and corner cases that may come up when converting to the COO format in order to ensure that the assemble and disassemble functionality is robust and will not cause issues down the line.

Tasks:

• [ ] Check that the SparseMatrixCOO class has assembleStorage() and disassembleStorage() methods defined
• [ ] Check that the assembleStorage() and disassembleStorage() methods properly update the MatrixState
• [ ] Check that assembleStorage() method properly allocates and generates the rowIdx, colIdx, and values vectors based off of the coefficients defined with the setCoefficients() method
• [ ] Work with the other COO developers to make sure that our tests are not conflicting in their assertions

Definition of done:

Evidence of unit tests that evaluate different aspects of the assembleStorage and disassembleStorage functionality (described above in the Tasks list) will be posted under this ticket with descriptions of what is being evaluated in each test.

[KyleVaughn]

Review by @jacob-umich

[jacob-umich]

@tjayasa Please fill out your issue soon so that I can provide feedback before it is due

[tjayasa]

@tjayasa Please fill out your issue soon so that I can provide feedback before it is due

Hey @jacob-umich, sorry for the delay, the issue description has been filled out and is ready for your review. Thanks!

[jacob-umich]

@tjayasa Thanks for your quick response. A few pieces of info that you might implement come to mind.

• As a part of your background, should you add how this task is contributing to the functional requirements?
• Would you want to test for incorrect input (i.e. if this method was called when the matrix is in the wrong state). Should this be added to your tasks?
• should there be a task to integrate your tests with cmake/make?

Also, I don't understand this:

Work with the other COO developers to make sure that our tests are conflicting in their assertions

Are you talking about other COO test developers, or do you mean just working with the people who are making the methods to make sure they pass?

[bkochuna]

On comment/thought on the interface design, but you can use intrinsic types (e.g. float or double) as simple arrays, and this gives the greatest portability (e.g. This is helpful for inter-language applications and GPU). Vector types and a file name would be interesting ways to overload the routine

On Mon, Oct 16, 2023 at 12:31 PM Thomas Jayasankar @.***> wrote:

@tjayasa https://github.com/tjayasa Please fill out your issue soon so that I can provide feedback before it is due

Hey @jacob-umich https://github.com/jacob-umich, sorry for the delay, the issue description has been filled out and is ready for your review. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/bkochuna/ners570f23-SpMV/issues/37#issuecomment-1764855335, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHRN4LJAVE6H3BAVBYL2ZLX7VOOFAVCNFSM6AAAAAA56SOGASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRUHA2TKMZTGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[jacob-umich]

@tjayasa hey just a reminder that I need to review your tests and you have to address the comments before Thursday at 6

[tjayasa]

@jacob-umich The initial tests that check the matrixState have been pushed to the coo branch. There are more tests to come, but feel free to start reviewing the ones that are there if you'd like.