bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add assembleStorage and disassembleStorage tests for CSR #39

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

To allow conversion between the CSR format and other SpMV formats (and vice versa), we require assembleStorage and disassembleStorage methods. This issue will develop tests to ensure these CSR methods are functioning correctly.

Tasks:

Definition of done:

This issue is considered done when the CSR assembleStorage and disassembleStorage tests all pass.

KyleVaughn commented 11 months ago

Review by @lwh1106

lwh1106 commented 11 months ago

Recommend to refer to the interface or data structure of SparseMatrix and implement some of them in CSR, especially for the assembleStorage() function.

lwh1106 commented 11 months ago

The description and tasks look great! I would have a question about one of the tasks. By saying the dataset in COO format, do we need to create all these examples by ourselves? Or are there other ways? We can demonstrate a bit of these here. Overall, it is good. You may also need to refer to your front end and back end when developing and finishing your tasks.

lwh1106 commented 10 months ago

Hi @AnvayPradhan I can see the test for the accessor, matvec, and view methods. It seems that the test for assembleStorage and disassembleStorage is still not pushed, right? Just let me know once you finish this so that I can review your work, thanks!