bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add assembleStorage and disassembleStorage methods for ELL #40

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

To allow conversion between the ELL format and other SpMV formats (and vice versa), we require assembleStorage and disassembleStorage methods. The assembleStorage method will take input locations (i, j) and non-zero (val) values and map them into the ELL format. The disassembleStorage method will do the inverse, that is, take the ELL fomrat and convert it to locations (i, j) and non-zero (val) values.

Tasks:

Definition of done:

This issue is considered done when the ELL assembleStorage and disassembleStorage tests all pass.

KyleVaughn commented 11 months ago

Review by @webberqu417

webberqu417 commented 11 months ago

Shouldn't the original format be the base SparseMatrix class instead of COO?

Also, consider adding a task that specifies creating the method and what the input arguments are.