bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add ELL accessor tests #49

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

This issue creates tests for ELL matrix access methods. The library is tested for being able to access a few elements related to the ELL matrix format - ELL column indices, and ELL matrix values. It also tests for the correct implementation for the state, and correct format, and prints relevant messages. Accessor testing is an important way to ensure the matrix information is stored and retrieved correctly.

Tasks:

Definition of done:

The accessor testing method is complete when all the relevant checks for the accessor method, rows, columns, ELL column indices, ELL matrix coefficients, state, and format are completed and the relevant messages for these tests - "Test X passed/failed" (where X is the relevant operation defined in tasks) are displayed. This method is important for testing the functioning of all ELL methods.

KyleVaughn commented 11 months ago

Review by @Lazy-Beee

Lazy-Beee commented 11 months ago

For the description, I think you can focus more on what the test is besides why the test is important. This can give the readers a basic understanding of the task before they continue to the task list. The same for the 'definition of done'. It would be better if you could define what this test function should be able to do when it's completed.