bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Add an ELL view method #53

Open KyleVaughn opened 11 months ago

KyleVaughn commented 11 months ago

Description:

When working with ELL matrices, it can be challenging to inspect and understand their content due to the specific storage format. Currently, there is no built-in method to view the ELL matrix in a human-readable format, hindering debugging and development processes. This issue proposes adding a new method to the existing codebase that will allow for a more user-friendly view specifically tailored for ELL matrices with output in a new file and also print the matrix.

Tasks:

Definition of done:

(Must print the matrix) was mentioned before as a part of the question.

The new method is added to the project and is documented. The method can successfully visualize ELL matrices. Appropriate tests are ran to verify the correctness of the method. The matout files and the print outputs look correct and user-friendly.

KyleVaughn commented 11 months ago

Review by @arsridha

arsridha commented 11 months ago

The issue is defined well. I have a couple of comments you could maybe consider: