search

bkochuna / ners570f23-SpMV

1 stars 0 forks source link

Ell accessor methods #65

Open jacob-umich opened 10 months ago

jacob-umich commented 10 months ago

This pull request starts working on many issues, but I believe the accessor methods' implementations are good. It compiles but does not execute without errors yet because most methods do not run. I believe the accessor method would run if it was called in the right context.

Resolves #49

Lazy-Beee commented 10 months ago

Review of ELL accessor https://github.com/bkochuna/ners570f23-SpMV/issues/49:

The ELL accessor method looks good and is well-documented.

For the getLongestRow() function, seems you did not free the memory allocated for rowLengths. Personally, I will choose to use the std::vector to store the row lengths.

arsridha commented 10 months ago

Review of ELL view method #53

The view method looks good. The condition in your if statement, compares a floating point type (i.e. val[i]) to an integer, so, when compiling you might see an error. I don't know how the code is structured for ELL,so, this might not be relevant, but, if val is a member of your class, then you'd probably need to do this->val like in some of the earlier methods.

jacob-umich commented 10 months ago

@AvirupSircar getNumRows, getNumCols, getNumNonZeros, getState and setCoefficient are all implemented in the parent class