JDS Branch

[rgrawe]

This is the branch for JDS. Review Issues 25 and 20 here.

[nzamb222]

Review of Add JDS Matrix Class issue #20 @shujhan . Default constructor look good, nice job. Your destructor needs to clear the memory for the colIdx , val , iterptr, and row . Consider adding delete[] and setting it to a null pointer in the destructor call in the .cpp file. The overloaded constructor is declared correctly, but I am unsure if you need to assign values to all the variables? I believe that is the job of the assembleStorage(). You can keep it like this however, just might be duplicated.

[rgrawe]

Review of Add JDS Matrix Class issue #20 @shujhan . Default constructor look good, nice job. Your destructor needs to clear the memory for the colIdx , val , iterptr, and row . Consider adding delete[] and setting it to a null pointer in the destructor call in the .cpp file. The overloaded constructor is declared correctly, but I am unsure if you need to assign values to all the variables? I believe that is the job of the assembleStorage(). You can keep it like this however, just might be duplicated.

The constructor should only be calling nrows and ncols. This is the format that I've assumed for the JDS constructor test. You can look at the other sparse matrix constructors for an example.

[shujhan]

Thanks for the comments. I have uploaded the revision version.

[shujhan]

@nzamb222 Thanks, changed it.

[shujhan]

Review #25 @rgrawe Looks good but will JDS class have .getFormat() method?

[rgrawe]

@shujhan No idea! I included it because the COO constructor test included it, but I can get rid of it if you think it's unnecessary.