Open KyleVaughn opened 1 month ago
@MattGranados Ready for review
Overall excellent description, list of tasks, and definition of done. The references to related issues aids in ease of understanding where to look for specifics of formatting and testing. Great work!
Comments:
_buildCoeff
attribute entails. i.e how is data stored in this attribute?Hi @NiloyGupta-UM have you created a pull request yet for your storage methods? Asking to make sure I can give a review
@MattGranados Sorry, this is done so late; only just saw this message. My work was already incorporated into a previous pull request. Here is the link to my specific commit in that pull request: link
Description:
For the JDS matrix class, implement the
assembleStorage
anddisassembleStorage
methods that convert the data stored in the_buildCoeff
attribute of the baseSparseMatrix
class to the format specified by the JDS format and vice versa. For a description of the JDS format this library will use, see #6 .Tasks:
assembleStorage
method that_buildCoeff
to the JDS-specific attributes defined by #6MatrixState
variable/enumerationdisassembleStorage
method that_buildCoeff
MatrixState
variable/enumerationDefinition of done:
assembleStorage
anddisassembleStorage
methods of the other sparse matrix types