bkochuna / ners570f24-SpMV

3 stars 0 forks source link

Add assembleStorage and disassembleStorage methods for JDS #49

Open KyleVaughn opened 1 month ago

KyleVaughn commented 1 month ago

Description:

For the JDS matrix class, implement the assembleStorage and disassembleStorage methods that convert the data stored in the _buildCoeff attribute of the base SparseMatrix class to the format specified by the JDS format and vice versa. For a description of the JDS format this library will use, see #6 .

Tasks:

Definition of done:

NiloyGupta-UM commented 3 weeks ago

@MattGranados Ready for review

MattGranados commented 3 weeks ago

Overall excellent description, list of tasks, and definition of done. The references to related issues aids in ease of understanding where to look for specifics of formatting and testing. Great work!

Comments:

  1. Description can potentially be expanded; provide a little more information on what the _buildCoeff attribute entails. i.e how is data stored in this attribute?
  2. Add what the name of the file containing the storage methods is. This would provide greater clarity as to where exactly these methods are being implemented.
MattGranados commented 2 weeks ago

Hi @NiloyGupta-UM have you created a pull request yet for your storage methods? Asking to make sure I can give a review

NiloyGupta-UM commented 1 week ago

@MattGranados Sorry, this is done so late; only just saw this message. My work was already incorporated into a previous pull request. Here is the link to my specific commit in that pull request: link