bkoelman / ResharperCodeContractNullability

Reports diagnostics, helping you to annotate your source tree with (Item)NotNull / (Item)CanBeNull attributes.
https://www.jetbrains.com/resharper/help/Code_Analysis__Code_Annotations.html
Apache License 2.0
26 stars 4 forks source link

Warning when inheriting from interface #5

Closed JakobChristensen closed 9 years ago

JakobChristensen commented 9 years ago

Hi

Great analyzer!

If I have an interface and two classes like this:

image

I get an error that "text" is not decorated in Derrived.Foo().

bkoelman commented 9 years ago

Hi Jakob, thanks for taking the time to report this.

A similar issue was fixed in v1.0.2 a few days ago. Can you verify if that fixes the problem for you?

The thing is, I cannot reproduce the problem in the latest version...

image

JakobChristensen commented 9 years ago

Hi Bart

Yep – that solved it!

Thought I was running on 1.0.2, but apparently not – probably did not restart Visual Studio.

Thanks for the help!

--Jakob

From: Bart Koelman [mailto:notifications@github.com] Sent: 23. september 2015 11:28 To: bkoelman/ResharperCodeContractNullability ResharperCodeContractNullability@noreply.github.com Cc: Jakob Hjorth Christensen jc@sitecore.net Subject: Re: [ResharperCodeContractNullability] Warning when inheriting from interface (#5)

Hi Jakob, thanks for taking the time to report this.

A similar issuehttps://github.com/bkoelman/ResharperCodeContractNullability/issues/3 was fixed in v1.0.2https://github.com/bkoelman/ResharperCodeContractNullability/releases/tag/v1.0.2 a few days ago. Can you verify if that fixes the problem for you?

The thing is, I cannot reproduce the problem in the latest version...

[image]https://cloud.githubusercontent.com/assets/10324372/10041652/e8767598-61e5-11e5-8a5c-4ffc54bb25f7.png

— Reply to this email directly or view it on GitHubhttps://github.com/bkoelman/ResharperCodeContractNullability/issues/5#issuecomment-142543534.

starkcolin commented 8 years ago

I still experience this error on 1.0.3 in the following situation, similar to the original bug report but in the specific scenario of: Concrete Class derives from Generic Class implements Generic Interface:

image

The error is "Parameter 'text' is missing nullability annotation."