search

bkonyi / FlutterGeofencing

Rough work for Flutter geofencing plugin
BSD 3-Clause "New" or "Revised" License
338 stars 220 forks source link

Add method to fetch registered geofence ids #37

Closed tashiwangdi closed 4 years ago

tashiwangdi commented 4 years ago

adding a method call to fetch registered geofence ids in android and ios. This would help in clearing the geofences before they are synced again.

tashiwangdi commented 4 years ago

Hi @bkonyi : Could you please review this PR when you can spare some time? Thanks.

bkonyi commented 4 years ago

Hi @bkonyi : Could you please review this PR when you can spare some time? Thanks.

Yes, I'll take a look. Thanks for being patient!

tashiwangdi commented 4 years ago

Hi @bkonyi

Did you get a chance to look at the changes? Thank you for your time.

-Tashi

tashiwangdi commented 4 years ago

Thank you @bkonyi for taking the time to review and for your comments. I have added a text widget in the example app to show registered geofence ids and update whenever one registers/de-registers a geofence.

bkonyi commented 4 years ago

Thank you @bkonyi for taking the time to review and for your comments. I have added a text widget in the example app to show registered geofence ids and update whenever one registers/de-registers a geofence.

Thanks for adding to the example. Once everything is dartfmt'ed I'm happy to merge this.

tashiwangdi commented 4 years ago

Thank you @bkonyi for taking the time to review and for your comments. I have added a text widget in the example app to show registered geofence ids and update whenever one registers/de-registers a geofence.

Thanks for adding to the example. Once everything is dartfmt'ed I'm happy to merge this.

Hi @bkonyi : dartfmted as commented. My editor setting had line wrapping at 140 chars against 80(default). Is this what you expected?

bkonyi commented 4 years ago

Thank you @bkonyi for taking the time to review and for your comments. I have added a text widget in the example app to show registered geofence ids and update whenever one registers/de-registers a geofence.

Thanks for adding to the example. Once everything is dartfmt'ed I'm happy to merge this.

Hi @bkonyi : dartfmted as commented. My editor setting had line wrapping at 140 chars against 80(default). Is this what you expected?

Excellent, much better :) Default Dart style calls for 80 character lines, so that's a typical requirement for Dart packages. Thank you!