search

bkorda / node-red-contrib-zway

GNU General Public License v3.0
5 stars 4 forks source link

old embedded jQuery module "multiple-select" v1.4.1 breaks monaco-editor in node-red 2.0.0 #9

Closed Steve-Mcl closed 2 years ago

Steve-Mcl commented 3 years ago

Describe issue Hi, much like the issue I raised on node-red-contrib-zigbee2mqtt, this repo also has an old version of "multiple-select" embedded in the static/ folder that breaks the new monaco editor (See here)

The issue is (i believe) specific to multiple-select V1.4.2 and below - see this issue: wenzhixin/multiple-select#483

Could you please update to V1.5.2 as it does not cause the editor to break.

Screens / Logs image

bkorda commented 2 years ago

Sorry, I have no soft and hardware to test, need to find a new device. Could you do a pull request?

Steve-Mcl commented 2 years ago

Hi, sorry, I don't have hardware either. All I can say is most of the other nodes which I flagged have just updated the local copy of the jQuery file

E.g. look at node-red-contrib-zigbee2mqtt and node-red-contrib-deconz change log.

bkorda commented 2 years ago

Hey, sorry for such a big silence. Will update it as soon as possible

bkorda commented 2 years ago

Fixed in node-red-contrib-zway@1.0.0