search

bkrem / react-d3-tree

:deciduous_tree: React component to create interactive D3 tree graphs
https://bkrem.github.io/react-d3-tree
MIT License
1.07k stars 270 forks source link

Why is react-transition-group such an old version and not upgraded? #248

Open nickluger opened 4 years ago

nickluger commented 4 years ago

What's the issue?

I'd like react-transition-group to be upgraded to a newer version. The old version is for example using componentWillReceiveProps which causes warnings in React@16.9+. I saw that you ignore react-transition-group in Greenkeeper, pinning it to version 1.1.3 while the current version is 4.3.0. Why's that? I saw some issues touching it like https://github.com/bkrem/react-d3-tree/issues/39, but that was 2017.

What could be done?

Upgrade react-transition-group, or maybe document in this issue here, why that's not possible currently.

What version of react-d3-tree are you using?

1.15.3

Workaround

If you don't need transitions set transitionDuration={0}. This PR is incredibly helpful: https://github.com/bkrem/react-d3-tree/pull/92, as the module is no longer used.

jerem-guy commented 2 years ago

Any news on that ?

I think it actually can be the cause of some issues with Jest testing as well : https://stackoverflow.com/questions/55380937/typeerror-cannot-read-property-baseval-of-undefined Upgrading to react-transition-group last version would solve the issue I guess.

Cheers, Jérémie