search

bkrem / react-d3-tree

:deciduous_tree: React component to create interactive D3 tree graphs
https://bkrem.github.io/react-d3-tree
MIT License
1.09k stars 270 forks source link

fix: treat node with empty children as leaf #408

Closed zhouhao closed 2 years ago

zhouhao commented 2 years ago

Hello @bkrem, thank you for your great package.

I feel it makes more sense here to treat node with empty children as leaves. WDYT?

bkrem commented 2 years ago

Hi @zhouhao,

Sorry about the wait, it's been a very busy week.

Agreed and this all looks great! Will try to get a patch release out for this in the next 24hrs.

I also think there is an issue open for this, which I'll link.

zhouhao commented 2 years ago

Thank you @bkrem ! No worries. ;-)

I guess this is the issue: https://github.com/bkrem/react-d3-tree/issues/395

bkrem commented 2 years ago

Closes #395

bkrem commented 2 years ago

Published as https://github.com/bkrem/react-d3-tree/releases/tag/v3.3.5

Thanks again for the fix! 🙌