search

bkrem / react-d3-tree

:deciduous_tree: React component to create interactive D3 tree graphs
https://bkrem.github.io/react-d3-tree
MIT License
1.06k stars 268 forks source link

Update package.json, added missing export types for module #465

Closed james-nair closed 7 months ago

james-nair commented 1 year ago

Added missing type output. Resolved vscode error for not finding type declaration for react-d3-tree package

hyper-dot commented 7 months ago

Why it is not merged till today :cry:

bkrem commented 7 months ago

Hey folks, sorry about this! I've had very little time to maintain this lib for the past year but tried to keep things moving on urgent fixes, this one clearly got away from me. Feel free to nudge as @hyper-dot has here on major annoyances like this.

I was under the impression that the existing root level types field was sufficient but clearly there was a gap in my TS dogfooding, presumably when using ES module resolution in VSCode as indicated.

Thank you for the original fix PR @JimmyNair 🙏 Will ping back here when published.

bkrem commented 7 months ago

Fixed in https://github.com/bkrem/react-d3-tree/releases/tag/v3.6.2

transfer1992 commented 7 months ago

Hey! Subscribers of this PR may have received some emails about me posting some concerns, but I just have educated myself and all is good. Sorry for the mess. Thanks for merging this!