search

bl0x / learn-fpga-amaranth

Code for Bruno Levy's learn-fpga tutorial written in Amaranth HDL
BSD 3-Clause "New" or "Revised" License
90 stars 12 forks source link

Update from Cat(a, Cat(b, Cat(c, d))) to Cat(a, b, c, d) #3

Closed josuah closed 1 year ago

josuah commented 1 year ago

It seems like it works in Amaranth, and since is among the first few sources I read, adjusting it here might help other people to get it right from the start.

Or maybe it was intentional?

I generated logs for each benchtests.

git checkout 975f018
git diff --stat 7807bd6  | while IFS='/ ' read test _; do echo $test; (cd $test; python ./bench.py >commit_975f018.log); done
git checkout 7807bd6
git diff --stat 975f018 | while IFS='/ ' read test _; do echo $test; (cd $test; python ./bench.py >commit_7807bd6.log); done

I then compared the output from each commit and it reported nothing

git diff --stat 975f018 | grep '|' | while IFS='/ ' read test _; do diff -u $test/commit_*.log; done
josuah commented 1 year ago

Related: https://github.com/amaranth-lang/amaranth/pull/765

bl0x commented 1 year ago

Hi @josuah , thanks for the PR! I've been meaning to look into this. I also only found out about the Cat(a, b,...) syntax halfway through the tutorial.