search

bl4ckscor3 / CeilingTorch

A Minecraft mod to make vanilla torches placeable on the ceiling.
https://curseforge.com/minecraft/mc-mods/ceiling-torch
MIT License
3 stars 3 forks source link

1.20 port #66

Closed gohkenytp closed 1 year ago

gohkenytp commented 1 year ago

Ported this mod to Minecraft 1.20

bl4ckscor3 commented 1 year ago

I don't understand your most recent comment. I appreciate you porting the mod, and in the usual way how pull requests go, I asked for changes to be made before the PR gets merged. There's no ill intent from my side.

I will be reviewing this again tomorrow as it's getting late here.

gohkenytp commented 1 year ago

OK. I sure hope this goes successful!

bl4ckscor3 commented 1 year ago

From my previous review comment, 4 points have not been addressed, as well as the comments I left on the code itself.

gohkenytp commented 1 year ago

Ok I did it already.

bl4ckscor3 commented 1 year ago

Not everything is addressed yet.

gohkenytp commented 1 year ago

Look, I tried to port it, but you didn't seem to understand.

bl4ckscor3 commented 1 year ago

I do understand. And I can just reiterate that I am happy you did the port. But it is lacking some necessary changes for it to be considered complete. I requested those changes to be made, that's how pull requests work. If you don't want to finish the port it's fine, I'll base mine off of yours once I get around to doing it. But unless you can address my previous comments, this is not getting merged.

gohkenytp commented 1 year ago

I don't want to finish this port sadly.

gohkenytp commented 1 year ago

Also, why are you halting progress on your port to 1.20 anyway?

bl4ckscor3 commented 1 year ago

Please see my comment on the other repository. There's no reason to crosspost.

gohkenytp commented 1 year ago

Not to be rude but, I just can't do it now. OK? Accept it. Maybe you can port it without me if you get a chance.