Closed gohkenytp closed 1 year ago
I don't understand your most recent comment. I appreciate you porting the mod, and in the usual way how pull requests go, I asked for changes to be made before the PR gets merged. There's no ill intent from my side.
I will be reviewing this again tomorrow as it's getting late here.
OK. I sure hope this goes successful!
From my previous review comment, 4 points have not been addressed, as well as the comments I left on the code itself.
Ok I did it already.
Not everything is addressed yet.
Look, I tried to port it, but you didn't seem to understand.
I do understand. And I can just reiterate that I am happy you did the port. But it is lacking some necessary changes for it to be considered complete. I requested those changes to be made, that's how pull requests work. If you don't want to finish the port it's fine, I'll base mine off of yours once I get around to doing it. But unless you can address my previous comments, this is not getting merged.
I don't want to finish this port sadly.
Also, why are you halting progress on your port to 1.20 anyway?
Please see my comment on the other repository. There's no reason to crosspost.
Not to be rude but, I just can't do it now. OK? Accept it. Maybe you can port it without me if you get a chance.
Ported this mod to Minecraft 1.20