search

bl4ckscor3 / CeilingTorch

A Minecraft mod to make vanilla torches placeable on the ceiling.
https://curseforge.com/minecraft/mc-mods/ceiling-torch
MIT License
3 stars 3 forks source link

Resource Pack Compat #74

Closed QwertRvg closed 4 months ago

QwertRvg commented 4 months ago

Can you please add resource pack support? So the mod simply loads the torch and particle textures that the vanilla torch uses? Otherwise the Ceiling Torch looks out of place when using a resource pack. image

bl4ckscor3 commented 4 months ago

It should already do that, since I don't touch models or textures. The only issue that could appear and which isn't fixable by the mod is if a resource pack changes the torch's block state file. In that case, the one from the ceiling torch doesn't match the vanilla one, and it has to be manually adapted.

Which Minecraft and Ceiling Torch versions are you using? Which resource pack is this?

QwertRvg commented 4 months ago

Hi, thanks for your response! I am on Minecraft version 1.20.1, Forge 47.2.0 and Ceiling Torch 1.28. And the Resource Pack I am using is Torches Reimagined.

bl4ckscor3 commented 4 months ago

Yup, as I expected the resource pack changes the blockstate files to redirect to its own model files. Frankly, I would consider this a bug in that resource pack, as it doesn't modify the vanilla torch's block model files instead. I attached a resource pack that fixes the ceiling torch visuals, but I'd suggest reporting this to the resource pack dev, as any block that uses the vanilla torch models will not take on the reimagined look.

Torches Reimagined fix for Ceiling Torch.zip

QwertRvg commented 4 months ago

thanks so much!