bl4k1st / hackerskeyboard

Automatically exported from code.google.com/p/hackerskeyboard
0 stars 0 forks source link

Slovenian layout problems #261

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hello!

First of all thank you for this excellent keyboard! I am discovering basic 
features like layouts and I came upon a problem.

1. The Slovenian layout doesn't contain a backslash (\). It should be an 
alternate key for Q. See image here for evidence:  
http://en.wikipedia.org/wiki/Keyboard_layout#South_Slavic_Latin
Currently Q does not have a pop-up menu.

2. This layout also has Ł mapped only to alternate K but it should also be 
alternate for L. It's a weird situation because on a hardware keyboard 
Shift+Alt Gr+K gives me & and Shift+Alt Gr+L gives me Ł.
You can consider this so minor it's not worth a fix because I honestly don't 
even know why this character is on the keyboard as it is not found in any 
Southern Slavic alphabet.

3. Perhaps the Slovenian layout should be renamed to Southern Slavic layout 
because it might offend some of your users.
Or perhaps you might consider duplicating the layout for many locales 
(Slovenian & Croatian & Bosnian & Latin Serbian).

I'm using version 1.33.1332 d27b51144b8e2 2012-07-03 on Dell Streak Mini (5" 
phone with Android 2.2). Yes, you read correctly its name contains Mini. :)

These issues are present in both portrait and landscape mode.

Thanks for your consideration.

Original issue reported on code.google.com by jasa.bar...@gmail.com on 4 Jul 2012 at 3:37

GoogleCodeExporter commented 8 years ago
For (1), thank you for reporting the bug, there seems to be something going 
wrong with resource loading in the current version or SDK. The alternates_for_q 
definition does contain the backslash, but it's not being loaded right from the 
resource definition. I'm investigating. I assume it worked right in earlier 
versions when the original contributor was testing it.

https://code.google.com/p/hackerskeyboard/source/browse/java/res/values-sk/donot
translate-keymap.xml
https://code.google.com/p/hackerskeyboard/source/browse/java/res/values-sk/donot
translate-altchars.xml

Here's debug data for the key data as loaded - note that "w" has the expected 
"|" alternate, but "q" is missing the backslash.

I/Keyboard( 6581): added key definition: KeyDebugFIXME(label=q shift=Q 
code=113:'q' x=0..48 y=2..66 edgeFlags=---- pop=1 res=2131034122)
I/Keyboard( 6581): added key definition: KeyDebugFIXME(label=w shift=W 
code=119:'w' x=48..96 y=2..66 edgeFlags=---- pop=2| res=2131034122)

For (2), I'm adding the extra mapping, it's a very easy change.

For (3), this is a bit difficult. Currently the keymaps don't have individual 
names, it uses the name of the locale (in this case for "sk") in the mapping. 
Making extra copies is a maintenance headache since I then need to remember to 
make all changes (such as the (2) addition) for all copies consistently. I'm 
working on redoing the mode selection logic anyway to decouple layouts from 
languages, and then it should be easier to do this.

Original comment by Klaus.We...@gmail.com on 4 Jul 2012 at 6:30

GoogleCodeExporter commented 8 years ago
Hang on, looks like I was looking at the wrong file, and there's a typo in the 
"sl" definition. I assume you mean the "sl" Slovenian 
(Slovenščina)/Bosnian/Croatian/Latin Serbian layout, and not "sk" for Slovak 
(Slovenčina)?

No offense intended, but these names are really confusing.

This should be fixed in revision e7939e3b644b, new version coming soon.

Original comment by Klaus.We...@gmail.com on 4 Jul 2012 at 7:01

GoogleCodeExporter commented 8 years ago
Please try v1.34rc4 (or later) from 
http://code.google.com/p/hackerskeyboard/downloads/list, and let me know if 
that works for you.

Original comment by Klaus.We...@gmail.com on 4 Jul 2012 at 7:14

GoogleCodeExporter commented 8 years ago
Yes, I was referring to the Slovenian layout (it's in the bug title).

I look forward to testing this, thank you.

Original comment by jasa.bar...@gmail.com on 4 Jul 2012 at 7:16

GoogleCodeExporter commented 8 years ago
Tested, both characters are now accessible. Thanks again.

Original comment by jasa.bar...@gmail.com on 4 Jul 2012 at 7:34

GoogleCodeExporter commented 8 years ago
Thanks for confirming.

The difficult bit for me is that the code and resources don't use the name 
"Slovenian" anywhere, just codes such as sk/sl. While testing, I just see the 
localized names such as Slovenščina/Slovenčina, so it's easy to get 
confused. I've already memorized more of ISO 631 than I'd consider 
reasonable... 

Original comment by Klaus.We...@gmail.com on 4 Jul 2012 at 7:43

GoogleCodeExporter commented 8 years ago
[bulk bug update]

The changes from the 1.34rcX prerelease series are included in version 1.37 as 
published on the Play Store, and this bug should be fixed. If it's still not 
working for you, please reopen or file a new bug. Thanks to everyone who helped 
with finding bugs and testing!

Original comment by Klaus.We...@gmail.com on 26 Dec 2013 at 7:12