blaa / WaveSync

Multi-room synchronised audio playback over shaky network connections and cheap (rasbperry pi) hardware.
MIT License
64 stars 13 forks source link

libwavesync: switch to time for timestamp #9

Closed ddimension closed 4 years ago

ddimension commented 4 years ago

Usage of DateTime library forced a lookup in filesystem everytime it has been called. This lead to a fs crash on an embedded device. With the patch, it even runs on standard routers with single core MIPS CPUs.

Switch all to time(), this reduced cpu usage by 50%.

blaa commented 4 years ago

This should also fix a problem I noted with differing timezones on machines. I didn't get to fix it yet though - thank you. ;-)

I pushed by dev branch audio-callback. It's a WIP of a new synchro algorithm (well - a part) for a truly bad devices (1 core, huge output buffer). I hope to finish it soon and probably correct synchronization also on better devices, but in the meantime, if you're on wavesync you might find it interesting.

ddimension commented 4 years ago

Hi Thomas,

thanks for your good software. I love it. I will test the audio-callback branch and give you info.

Kind regards,

André

Am 10.05.20 um 22:30 schrieb Tomasz bla Fortuna:

This should also fix a problem I noted with differing timezones on machines. I didn't get to fix it yet though - thank you. ;-)

I pushed by dev branch audio-callback. It's a WIP of a new synchro algorithm (well - a part) for a truly bad devices (1 core, huge output buffer). I hope to finish it soon and probably correct synchronization also on better devices, but in the meantime, if you're on wavesync you might find it interesting.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blaa/WaveSync/pull/9#issuecomment-626385197, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPA77EQJQMISL7ERXHCRITRQ4FHZANCNFSM4M5LPA3A.

blaa commented 4 years ago

I love that someone finds it useful.

This branch might be a bit too early for testing per se. Give me some time and it should be better than current master.

Cheers and thank you,

On 11 May 2020 21:33:54 CEST, ddimension notifications@github.com wrote:

Hi Thomas,>

thanks for your good software. I love it.> I will test the audio-callback branch and give you info.>

Kind regards,>

André>

Am 10.05.20 um 22:30 schrieb Tomasz bla Fortuna:>

This should also fix a problem I noted with differing timezones on machines. I didn't get to fix it yet though - thank you. ;-)>

I pushed by dev branch audio-callback. It's a WIP of a new synchro algorithm (well - a part) for a truly bad devices (1 core, huge output buffer). I hope to finish it soon and probably correct> synchronization also on better devices, but in the meantime, if you're on wavesync you might find it interesting.>

—> You are receiving this because you authored the thread.> Reply to this email directly, view it on GitHub https://github.com/blaa/WaveSync/pull/9#issuecomment-626385197, or unsubscribe>

https://github.com/notifications/unsubscribe-auth/ABPA77EQJQMISL7ERXHCRITRQ4FHZANCNFSM4M5LPA3A.>

-- > You are receiving this because you modified the open/close state.> Reply to this email directly or view it on GitHub:> https://github.com/blaa/WaveSync/pull/9#issuecomment-626912375

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

ddimension commented 4 years ago

Hi!

Am 11.05.20 um 21:58 schrieb Tomasz bla Fortuna:

I love that someone finds it useful.

Because it's made good. Clear design with minimal dependencies. Easy to jump into and to mod/experiment.>

This branch might be a bit too early for testing per se. Give me some time and it should be better than current master.

Of course I distributed it. And it seems to have better sync. I could move the tolerance from 100ms to default value. Load is also fine. Hardcore test tomorrow in the office;-)

BTW: If you use APs with openwrt there's a trick to make multicast reliable (if that's possible). Set multicast_to_unicast=1 in ssid config.>

Cheers and thank you, Kind regards,

André