blab-lab / wave_viewer

Wave Viewer is a Matlab-based analysis tool for speech waveforms.
GNU General Public License v2.0
6 stars 2 forks source link

Introduces quickzoom, new hotkey to toggle formants #1

Closed cwnaber closed 4 years ago

cwnaber commented 4 years ago

Additions aimed at optimizing workflow when segmenting. Changes include:

1.) A new hotkey 't' can toggle formants on/off. This hotkey just calls the same code as when a user clicks the Toggle Formants button. No new functions were added.

2.) A new function expand_btw_ax_uev places the axis markers (green and red bars) just before the first user event and just after the final user event, then expands to those axis markers. This is intended for workflows where the UEVs already exist and are generally in the right place, but the user still wants to do some small-scale UEV adjustments. The function is modeled after the existing "expand" function, expand_btw_ax_markers . A new associated hotkey 'q' (quickzoom?) is included.

3.) Revised help text to include two new hotkeys.

sbakst commented 4 years ago

Worked for me! I tested on data that had been forced-aligned.

cwnaber commented 4 years ago

I agree on all accounts. 1.) Help text has proper carriage return after 'q' now. 2.) When there's one user event, 'q' will still quickzoom to relatively broad range (400 ms) surrounding that user event. If there's a specific workflow we're expecting to use that for, we can adjust that 400 ms value to something else. Otherwise I'll just leave it there for now.

cwnaber commented 4 years ago

I'm still learning what buttons do -- didn't mean to close and reopen the pull request!

cwnaber commented 4 years ago

Per convo last week:

Given previous consensus, we should be ready to merge now.